feat: add validFor function to return the validity interval #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
changed the title
There was a problem hiding this comment.
Pull Request Overview
Adds a helper to compute how long an IPNS record remains valid and exposes protobuf entry points.
- Introduces
validForto calculate milliseconds until expiration or throw on invalid records - Expands tests in
validator.spec.tsto covervalidForbehavior - Updates
package.jsonexports to include the protobuf directory
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/validator.spec.ts | Added tests for validFor and updated imports |
| src/validator.ts | Implemented validFor and adjusted imports |
| package.json | Exposed ./pb protobuf exports |
Comments suppressed due to low confidence (2)
test/validator.spec.ts:117
- This test is intended to cover the branch where
record.validityis null, but it currently nullsvalidityTypeinstead. Change it torecord.validity = null as anyso thevalidForfunction's null-validity check is exercised.
record.validityType = null as any
src/validator.ts:114
- [nitpick] Update the parameter description to reflect that this function calculates expiration, e.g.,
@param record - The IPNS record to evaluate for expiration.
* @param record - The IPNS record to validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
validForfunction to which returns the number of milliseconds until the record expires.Open questions
expiresInorgetExpiry